Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_installer: exclude more from build-from-source warning. #10058

Merged

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Dec 18, 2020

We should only complain when installing requested formulae that aren't currently installed.

We should only complain when installing requested formulae that aren't
currently installed.
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Dec 18, 2020
@MikeMcQuaid MikeMcQuaid changed the title formula_installer: exclude dependencies from build-from-source warning. formula_installer: exclude more from build-from-source warning. Dec 18, 2020
@BrewTestBot
Copy link
Member

BrewTestBot commented Dec 18, 2020

Review period ended.

@MikeMcQuaid MikeMcQuaid merged commit 7333c46 into Homebrew:master Dec 18, 2020
@MikeMcQuaid MikeMcQuaid deleted the build_from_source_dependencies branch December 18, 2020 15:25
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 18, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants