New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
livecheck: split cask versions into sub-versions #10376
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
# typed: strict | ||
# frozen_string_literal: true | ||
|
||
module Homebrew | ||
module Livecheck | ||
# A formula or cask version, split into its component sub-versions. | ||
# | ||
# @api private | ||
class LivecheckVersion | ||
extend T::Sig | ||
|
||
include Comparable | ||
|
||
sig { params(formula_or_cask: T.any(Formula, Cask::Cask), version: Version).returns(LivecheckVersion) } | ||
def self.create(formula_or_cask, version) | ||
versions = case formula_or_cask | ||
when Formula | ||
[version] | ||
when Cask::Cask | ||
version.to_s.split(/[,:]/).map { |s| Version.new(s) } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not blocking but if there's a chance for tests for any of this that might be nice? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We’re considering getting rid of |
||
else | ||
T.absurd(formula_or_cask) | ||
end | ||
new(versions) | ||
end | ||
|
||
sig { returns(T::Array[Version]) } | ||
attr_reader :versions | ||
|
||
sig { params(versions: T::Array[Version]).void } | ||
def initialize(versions) | ||
@versions = versions | ||
end | ||
|
||
sig { params(other: T.untyped).returns(T.nilable(Integer)) } | ||
def <=>(other) | ||
return unless other.is_a?(LivecheckVersion) | ||
|
||
lversions = versions | ||
rversions = other.versions | ||
max = [lversions.count, rversions.count].max | ||
l = r = 0 | ||
|
||
while l < max | ||
a = lversions[l] || Version::NULL | ||
b = rversions[r] || Version::NULL | ||
|
||
if a == b | ||
l += 1 | ||
r += 1 | ||
next | ||
elsif !a.null? && b.null? | ||
return 1 if a > Version::NULL | ||
|
||
l += 1 | ||
elsif a.null? && !b.null? | ||
return -1 if b > Version::NULL | ||
|
||
r += 1 | ||
else | ||
return a <=> b | ||
end | ||
end | ||
|
||
0 | ||
end | ||
end | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or rename the file
livecheck_version.rb
maybe?