New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
version: add new Version::Parser class
#10378
Merged
SeekingMeaning
merged 2 commits into
Homebrew:master
from
SeekingMeaning:version-regexes
Jan 25, 2021
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| # typed: true | ||
| # frozen_string_literal: true | ||
|
|
||
| class Version | ||
| # @api private | ||
| class Parser | ||
| extend T::Sig | ||
| extend T::Helpers | ||
| abstract! | ||
|
|
||
| sig { abstract.params(spec: Pathname).returns(T.nilable(String)) } | ||
| def parse(spec); end | ||
| end | ||
|
|
||
| # @api private | ||
| class RegexParser < Parser | ||
| extend T::Sig | ||
| extend T::Helpers | ||
| abstract! | ||
|
|
||
| sig { params(regex: Regexp, block: T.nilable(T.proc.params(arg0: String).returns(String))).void } | ||
| def initialize(regex, &block) | ||
| super() | ||
| @regex = regex | ||
| @block = block | ||
| end | ||
|
|
||
| sig { override.params(spec: Pathname).returns(T.nilable(String)) } | ||
| def parse(spec) | ||
| match = @regex.match(process_spec(spec)) | ||
| return if match.blank? | ||
|
|
||
| version = match.captures.first | ||
| return if version.blank? | ||
| return @block.call(version) if @block.present? | ||
|
|
||
| version | ||
| end | ||
|
|
||
| sig { abstract.params(spec: Pathname).returns(String) } | ||
| def process_spec(spec); end | ||
| end | ||
|
|
||
| # @api private | ||
| class UrlParser < RegexParser | ||
| extend T::Sig | ||
|
|
||
| sig { override.params(spec: Pathname).returns(String) } | ||
| def process_spec(spec) | ||
| spec.to_s | ||
| end | ||
| end | ||
|
|
||
| # @api private | ||
| class StemParser < RegexParser | ||
| extend T::Sig | ||
|
|
||
| SOURCEFORGE_DOWNLOAD_REGEX = %r{((?:sourceforge\.net|sf\.net)/.*)/download$}.freeze | ||
| NO_FILE_EXTENSION_REGEX = /\.[^a-zA-Z]+$/.freeze | ||
|
|
||
| sig { override.params(spec: Pathname).returns(String) } | ||
| def process_spec(spec) | ||
| return spec.basename.to_s if spec.directory? | ||
|
|
||
| spec_s = spec.to_s | ||
| return spec.dirname.stem if spec_s.match?(SOURCEFORGE_DOWNLOAD_REGEX) | ||
| return spec.basename.to_s if spec_s.match?(NO_FILE_EXTENSION_REGEX) | ||
|
|
||
| spec.stem | ||
| end | ||
| end | ||
| end | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any unit tests for these would be lovely but non-blocking.