Remove old cctools references now that only ruby-macho is used.

[woodruffw]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew tests with your changes locally?

---

Continuation of #1051. The big changes here are that Keg#require_install_name_tool? is now Keg#require_relocation? and OS::Mac.{install_name_tool,otool} are removed.

Other notes:

We still check for otool and install_name_tool behavior in extend/os/mac/diagnostic.rb, even though both are currently eliminated entirely from the codebase.

Is it worth keeping checks like check_for_bad_install_name_tool? A cursory search of the core shows that at least 11 formulae invoke it directly, rather than using our ruby implementation.

cc @UniqMartin, @MikeMcQuaid

[MikeMcQuaid]

Is it worth keeping checks like check_for_bad_install_name_tool

In that case it's worth renaming but adding to our compat/ layer.

[MikeMcQuaid]

Thanks again @woodruffw!

[woodruffw]

In that case it's worth renaming but adding to our compat/ layer.

Got it! I'll also look into changing those formula to use ruby-macho instead.

[UniqMartin]

Nice work here and in #1051! If you feel like leveraging more of ruby-macho's capabilities in Homebrew, you could look into relocating and cleaning up bogus RPATHs. This could also help with making a few more bottles relocatable (cf. #371), though admittedly RPATHs are still not that prevalent among Homebrew formulae, so the impact won't be massive.

And then there was also the idea of adding some form of validation of the install name in Homebrew/homebrew-core#4655 (comment) which also falls into the realm of Mach-O related tweaks in Homebrew, thus something you might want to look into.

[woodruffw]

Thanks!

I'll read those issues and see what I can do about them. Expect PRs in a few days 😄