Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew.sh: fix brew --version outside HOMEBREW_REPOSITORY. #1090

Merged
merged 1 commit into from
Sep 23, 2016
Merged

brew.sh: fix brew --version outside HOMEBREW_REPOSITORY. #1090

merged 1 commit into from
Sep 23, 2016

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Sep 22, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

CC @DomT4 who saw this.

Copy link
Member

@DomT4 DomT4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that being the root cause of the issue does make sense, how didn't I put together 2+2 here. LGTM. Thanks!

@DomT4 DomT4 merged commit d3a2934 into Homebrew:master Sep 23, 2016
@MikeMcQuaid MikeMcQuaid deleted the brew-version-repository branch September 23, 2016 06:56
@alex-ruehe alex-ruehe mentioned this pull request Sep 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants