Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #10880 from Bo98/cli-stronger-types" #10907

Closed
wants to merge 1 commit into from

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Just in case we need it.

Fixes #10906.

This reverts commit 25373a1, reversing
changes made to a045cd7.

@carlocab carlocab added the critical Critical change which should be shipped as soon as possible. label Mar 22, 2021
@carlocab carlocab requested a review from Bo98 March 22, 2021 22:08
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@carlocab
Copy link
Member Author

carlocab commented Mar 22, 2021

Not sure why git thought I am reverting a045cd7. I'm pretty sure I'm reverting the other parent, 8e98ce6.

@Bo98
Copy link
Member

Bo98 commented Mar 22, 2021

It was somewhat expected there would be breakages. It's why I wanted to wait for a new tag first.

#10908 will fix the error reported in #10906.

@carlocab
Copy link
Member Author

Nice. I'll just leave this here just in case, but I don't expect that it'll need to be merged.

@carlocab
Copy link
Member Author

Don't think this will be needed anymore.

@carlocab carlocab closed this Mar 23, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brew uses --installed causes error about appdir
3 participants