Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert allowing timeouts for commands and downloads #10922

Merged
merged 2 commits into from Mar 24, 2021
Merged

Revert allowing timeouts for commands and downloads #10922

merged 2 commits into from Mar 24, 2021

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Mar 24, 2021 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Reverts #10864 and #10898

Fixes #10913 (for real this time, I hope)

This PR reverts the PRs adding timeouts. The changes broke custom download strategies. As mentioned in #10919, alternative ways of adding timeouts can (should) be explored.

@Rylan12
Revert "Merge pull request Homebrew#10898 from reitermarkus/audit-tim…
0b8a9bc 
…eout"

This reverts commit 6eaeba1, reversing
changes made to 28b1765.
@Rylan12
Revert "Merge pull request Homebrew#10864 from reitermarkus/command-t…
57b2660 
…imeout"

This reverts commit d55bdd3, reversing
changes made to 3c3bf1c.
@Rylan12 Rylan12 added the critical Critical change which should be shipped as soon as possible. label Mar 24, 2021
@request-info

This comment has been minimized.

Sign in to view
@request-info request-info bot added the needs response Needs a response from the issue/PR author label Mar 24, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@Rylan12 Rylan12 mentioned this pull request Mar 24, 2021
Closed
7 tasks
@Rylan12 Rylan12 removed the needs response Needs a response from the issue/PR author label Mar 24, 2021
@Rylan12 Rylan12 enabled auto-merge March 24, 2021 05:30
@Rylan12 Rylan12 merged commit 6f9b4b8 into Homebrew:master Mar 24, 2021
@Rylan12 Rylan12 deleted the revert-timeout branch March 24, 2021 05:50
@Rylan12 Rylan12 mentioned this pull request Mar 24, 2021
Merged
7 tasks
@reitermarkus reitermarkus mentioned this pull request Mar 24, 2021
Merged
7 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recent timeout addition set to nil causes many old systems using this to die.
2 participants
@Rylan12 @BrewTestBot