Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: no more cask exceptions #10926

Merged
merged 2 commits into from Mar 25, 2021
Merged

docs: no more cask exceptions #10926

merged 2 commits into from Mar 25, 2021

Conversation

SMillerDev
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This is pretty confusing since all these are deprecated in core. We should just remove this.

@BrewTestBot
Copy link
Member

Review period will end on 2021-03-25 at 15:18:37 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 24, 2021
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 25, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@SMillerDev SMillerDev merged commit 04d1142 into master Mar 25, 2021
@SMillerDev SMillerDev deleted the SMillerDev-patch-2 branch March 25, 2021 19:04
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants