Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-bot: cleanup etc/var after each build. #1100

Merged
merged 1 commit into from
Sep 23, 2016
Merged

test-bot: cleanup etc/var after each build. #1100

merged 1 commit into from
Sep 23, 2016

Conversation

MikeMcQuaid
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

This has been causing issues when bottling files that are installed to these paths due to the diff algorithm we use for figuring out whether files installed into etc/var belong to a given bottle.

@zmwangx
Copy link
Contributor

zmwangx commented Sep 23, 2016

Actually Cellar and stuff need cleanup too.

ilovezfs
ilovezfs suggested changes Sep 23, 2016
View reviewed changes
Copy link
Contributor

@ilovezfs ilovezfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically anything covered originally by the git clean needs a new wipe procedure

@MikeMcQuaid
test-bot: cleanup Cellar/etc/var after each build.
28a3cec 
This has been causing issues when bottling files that are installed to
these paths due to the diff algorithm we use for figuring out whether
files installed into etc/var belong to a given bottle. Additionally,
sometimes not all formulae were uninstalled which meant `brew doctor`
would fail.
@MikeMcQuaid MikeMcQuaid merged commit 8724e11 into Homebrew:master Sep 23, 2016
@MikeMcQuaid MikeMcQuaid deleted the test-bot-etc-var branch September 23, 2016 18:03
@ilovezfs ilovezfs mentioned this pull request Sep 26, 2016
Closed
@ilovezfs
Copy link
Contributor

Travis seems to need its own cure :( #1150

@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zmwangx zmwangx zmwangx approved these changes

@ilovezfs ilovezfs ilovezfs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MikeMcQuaid @zmwangx @ilovezfs