New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formula#bottle_hash
: various fixes/updates.
#11088
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
added
the
critical
Critical change which should be shipped as soon as possible.
label
Apr 9, 2021
MikeMcQuaid
changed the title
Formula#bottle_hash: various fixes/updates.
Apr 9, 2021
Formula#bottle_hash
: various fixes/updates.
BrewTestBot
previously approved these changes
Apr 9, 2021
BrewTestBot
previously approved these changes
Apr 9, 2021
Bo98
previously approved these changes
Apr 9, 2021
It's dramatically more human readable for very little difference in space.
- remove `cellar` because it's no longer global - remove `prefix` because it's no longer customisable - add `cellar` for each bottle tag - fix `url` for GitHub Packages
MikeMcQuaid
removed
the
critical
Critical change which should be shipped as soon as possible.
label
Apr 9, 2021
MikeMcQuaid
requested review from
BrewTestBot
and removed request for
BrewTestBot
April 9, 2021 15:29
Review period will end on 2021-04-12 at 13:08:31 UTC. |
BrewTestBot
added
the
waiting for feedback
Merging is blocked until sufficient time has passed for review
label
Apr 9, 2021
MikeMcQuaid
added
the
critical
Critical change which should be shipped as soon as possible.
label
Apr 9, 2021
BrewTestBot
removed
the
waiting for feedback
Merging is blocked until sufficient time has passed for review
label
Apr 9, 2021
Review period skipped due to |
BrewTestBot
approved these changes
Apr 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cellar
because it's no longer globalprefix
because it's no longer customisablecellar
for each bottle tagurl
for GitHub Packages. This will fix the formulae.brew.sh URLs being broken (https://formulae.brew.sh/api/formula/hello.json)While we're here:
JSON.pretty_generate
globally as it's dramatically more human readable for very little difference in space (and we've used it a few other places already)