Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always take latest item in Sparkle strategy. #11171

Merged
merged 1 commit into from Apr 17, 2021

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Apr 16, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The first item is not necessarily the latest, so sort the items by date first. Secondly, sort by version in case some versions were released at the same time.

Fixes breakage introduced by #11146.

@reitermarkus reitermarkus added the critical Critical change which should be shipped as soon as possible. label Apr 16, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

BrewTestBot
BrewTestBot previously approved these changes Apr 16, 2021
@Yann-R
Copy link
Contributor

Yann-R commented Apr 17, 2021

Thanx for the fix.
As a side-effect:

  • will the fixed strategy for sparkle automatically select only among the compatible versions according to the sparkle:minimumSystemVersiontag? e.g. in https://updates.devmate.com/com.runtimesharks.dndme.xml
  • or will it always select the latest item, compatible or not with the host performing the livecheck?

@reitermarkus
Copy link
Member Author

It will always select the latest, ignoring the system version. The livecheck really shouldn't depend on the macOS version, in theory even running brew livecheck on Linux should yield the same version.

@Yann-R
Copy link
Contributor

Yann-R commented Apr 17, 2021

@reitermarkus

The livecheck really shouldn't depend on the macOS version

OK 👍
When brew livecheck raises a version clearly tagged as "uncompatible" with the host, it may be a bit frustrating for certain uses. But if it is so by design, no problem!
Thanks.

@github-actions github-actions bot added the outdated PR was locked due to age label May 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants