Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download_strategy: never verbosely untar #1129

Merged
merged 1 commit into from
Sep 25, 2016

Conversation

zmwangx
Copy link
Contributor

@zmwangx zmwangx commented Sep 24, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

I was responsible for adding the v flag to tar in d7b6230, and I have to admit, I regretted the decision pretty soon. The verbose mode of tar is just too pointlessly verbose. Today I'm finally fed up after having to scroll through this. Let's get rid of it.

The verbose mode of tar is too pointlessly verbose.
@zmwangx
Copy link
Contributor Author

zmwangx commented Sep 25, 2016

The verbose mode is especially crazy when you deal with something like boost, where there are 12k+ files in the bottle and you get 800KB+ worth of useless logs in a matter of seconds (~76KB even when gzipped).

@MikeMcQuaid
Copy link
Member

I agree. It's also worth noting tar xvf can actually slow down the extraction as it blocks on writing to the terminal.

@MikeMcQuaid MikeMcQuaid merged commit e5274c0 into Homebrew:master Sep 25, 2016
@zmwangx zmwangx deleted the tar-no-verbose branch September 25, 2016 10:55
@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants