New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add brew link --HEAD
#11397
Merged
Merged
Add brew link --HEAD
#11397
Changes from 26 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
8de9baa
Add `brew link --HEAD`
212b648
Update usage message
f92300f
Update Library/Homebrew/cmd/link.rb
cnnrmnn d46881c
Rename `to_kegs` to `to_keg`
d754c0f
Update tests for `to_keg`
15dcc6f
Add `to_kegs`
f23d4d4
Switch to using `to_keg` and `to_kegs`
fe9a9bb
Rename `to_keg` to `to_default_kegs`
137914d
Rename `method` `:keg` to `:default_kegs`
49aa057
Rename `resolve_keg` to `resolve_default_keg`
2bfdbc6
Rename missed `to_keg`
3637924
Fix style
08bbb95
Add `to_kegs` test
26a3218
Deprecate `method: :keg`
b1ce7ef
Update Library/Homebrew/cli/named_args.rb
cnnrmnn 2938b27
Update `to_default_kegs` tests
cad6654
Update `to_kegs` tests
0938500
Update Library/Homebrew/test/cli/named_args_spec.rb
cnnrmnn fa9a525
Add `to_latest_kegs`
b72f5ef
Change `brew link` to use `to_latest_kegs`
6f005ca
Rename memoized variable
e977f35
Warn if no `HEAD` keg installed w/ `--HEAD`
074face
Start catching all nil kegs
c18c931
Fix tests
3b02439
Update Library/Homebrew/cli/named_args.rb
cnnrmnn 73ef297
Update Library/Homebrew/cli/named_args.rb
cnnrmnn b81a522
Add tests for `to_latest_kegs`
0a16142
Fix style
d50b323
Fix `to_kegs` test
ef4c401
Change `kegs` map to array
074b2d6
Clean up and fix typecheck issue
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MikeMcQuaid is this going to be a backward-incompatible change? It looks like
Homebrew::CLI::NamedArgs
is in the private API butHomebrew::CLI::Args#named
is a public method that returns aNamedArgs
array. I wonder, then, if the@api private
label here is incorrect.In fact, I realized that I'm using
args.named.to_formulae
in a few taps, not realizing it wasn't a public method.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is. Ideally we'd allow but deprecate (on the next minor version e.g. add a commented out
# odeprecated
) the existing naming.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MikeMcQuaid should the
@api
level be changed?