software_spec: improve bad manifest error message. #11412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
added
the
critical
|
Review period skipped due to |
BrewTestBot
previously approved these changes
May 19, 2021
MikeMcQuaid
force-pushed
the
improve_github_packages_json_manifest_error
branch
from
670b527
to
1136399
Compare
BrewTestBot
previously approved these changes
May 19, 2021
Let's complain immediately after fetching if there's something wrong and improve the error message to make it clearer what's going on. Inspired by #76336.
MikeMcQuaid
force-pushed
the
improve_github_packages_json_manifest_error
branch
from
1136399
to
60ab6b8
Compare
BrewTestBot
approved these changes
May 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's complain immediately after fetching if there's something wrong and improve the error message to make it clearer what's going on.
Inspired by Homebrew/homebrew-core#76336.