Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linkage_checker: add libatomic #11466

Merged
merged 1 commit into from May 31, 2021
Merged

linkage_checker: add libatomic #11466

merged 1 commit into from May 31, 2021

Conversation

danielnachun
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@BrewTestBot
Copy link
Member

Review period will end on 2021-06-01 at 07:41:04 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label May 31, 2021
@danielnachun
Copy link
Member Author

This library is part of the GCC runtime libs and we've now encountered an example of something that links to it: https://github.com/Homebrew/linuxbrew-core/pull/23339.

@iMichka iMichka enabled auto-merge May 31, 2021 07:49
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label May 31, 2021
@MikeMcQuaid
Copy link
Member

Thanks @danielnachun!

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label May 31, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@iMichka iMichka merged commit cf8794e into Homebrew:master May 31, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 1, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2021
@danielnachun danielnachun deleted the add_libatomic branch July 11, 2022 00:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@iMichka iMichka iMichka approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danielnachun @BrewTestBot @MikeMcQuaid @iMichka