Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diagnostic: add check for broken taps #11473

Merged
merged 2 commits into from
Jun 2, 2021
Merged

diagnostic: add check for broken taps #11473

merged 2 commits into from
Jun 2, 2021

Commits on Jun 1, 2021

  1. diagnostic: add check for broken taps 

    Detect half-baked core taps that show up on a fairly regular basis (e.g. Homebrew#11465).

The logic is simple enough: Since an improper tap wouldn't have a complete Git config, and is always somewhere below `HOMEBREW_REPOSITORY`, any Git operation would look at the Brew repo instead. We simply need to test for any of:

1. Empty tap origin
2. Empty tap HEAD
3. Tap HEAD == Brew HEAD
    Adrian Ho committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    c7bbb90 View commit details
    Browse the repository at this point in the history

  2. Unrefactor broken tap 

    Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
    @gromgit @MikeMcQuaid
    2 people authored and Adrian Ho committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    1cf8b43 View commit details
    Browse the repository at this point in the history