Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow anonymous access in private registries #11822

Merged
merged 1 commit into from Aug 5, 2021

Conversation

yahavi
Copy link

@yahavi yahavi commented Aug 4, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Followup #11766

Currently when HOMEBREW_ARTIFACT_DOMAIN is configured and HOMEBREW_DOCKER_REGISTRY_TOKEN is not, a default QQ== access token is used to authenticate with private registries.
This PR change this behavior: If HOMEBREW_ARTIFACT_DOMAIN is configured, always use the token configured in HOMEBREW_DOCKER_REGISTRY_TOKEN, even if empty.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work again!

@MikeMcQuaid MikeMcQuaid merged commit 6bb3699 into Homebrew:master Aug 5, 2021
@yahavi yahavi deleted the registry-annonymous-access branch August 6, 2021 08:35
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants