Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew.rb: remove gem setup for stackprof #11843

Merged
merged 1 commit into from Aug 11, 2021
Merged

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Aug 11, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

GEM_HOME and GEM_PATH are already set here, so setting up the gem environment here is not necessary and causes issues due to the assumption that standalone/load_path is run first. This fixes stackprof not working.

This could be refined further so that we don't allow GEM_* bleeding and instead insert the relevant directory into the load path via a Ruby command arg (like we do for intergration tests), to ensure better consistency in runtime behaviour between brew prof runs and regular env-filtered runs. That is however an extension of this PR rather than an alternative solution.

Closes #11799

@BrewTestBot
Copy link
Member

Review period will end on 2021-08-12 at 01:21:59 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 11, 2021
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know a ton about gem loading and the like but this seems to make sense and works fine locally

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @Bo98!

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Aug 11, 2021
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 11, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid MikeMcQuaid merged commit 79655bf into Homebrew:master Aug 11, 2021
@Bo98 Bo98 deleted the stackprof branch August 11, 2021 12:30
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants