brew.rb: remove gem setup for stackprof #11843
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?GEM_HOME
andGEM_PATH
are already set here, so setting up the gem environment here is not necessary and causes issues due to the assumption thatstandalone/load_path
is run first. This fixes stackprof not working.This could be refined further so that we don't allow
GEM_*
bleeding and instead insert the relevant directory into the load path via a Ruby command arg (like we do for intergration tests), to ensure better consistency in runtime behaviour betweenbrew prof
runs and regular env-filtered runs. That is however an extension of this PR rather than an alternative solution.Closes #11799