Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typecheck: allow typecheck command to run on Apple Silicon #11845

Merged
merged 1 commit into from
Aug 11, 2021
Merged

typecheck: allow typecheck command to run on Apple Silicon #11845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 0 additions & 7 deletions Library/Homebrew/dev-cmd/typecheck.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ def typecheck_args
Homebrew::CLI::Parser.new do
description <<~EOS
Check for typechecking errors using Sorbet.

Not (yet) working on Apple Silicon.
EOS
switch "--fix",
description: "Automatically fix type errors."
Expand Down Expand Up @@ -44,11 +42,6 @@ def typecheck_args

sig { void }
def typecheck
# TODO: update description above if removing this.
if Hardware::CPU.arm? || Hardware::CPU.in_rosetta2?
raise UsageError, "not (yet) working on Apple Silicon or Rosetta 2!"
end

args = typecheck_args.parse

Homebrew.install_bundler_gems!(groups: ["sorbet"])
Expand Down