Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: revert the revert of #11818 and #11819 #11877

Merged
merged 2 commits into from Aug 18, 2021

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Aug 18, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The better fix was Homebrew/homebrew-test-bot#654

@iMichka iMichka added the critical Critical change which should be shipped as soon as possible. label Aug 18, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@iMichka iMichka merged commit 6f41861 into Homebrew:master Aug 18, 2021
@iMichka iMichka deleted the revert3 branch August 18, 2021 15:20
@iMichka
Copy link
Member Author

iMichka commented Aug 18, 2021

cc @dawidd6 and @sudoforge

@sudoforge
Copy link

Yep, Homebrew/homebrew-test-bot#654 is the right solution. Thanks for the ping!

@github-actions github-actions bot added the outdated PR was locked due to age label Sep 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants