Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_auditor: use brewed curl for homepage check when needed #11896

Merged
merged 1 commit into from Aug 21, 2021

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Aug 20, 2021

If the download url is using brewed curl, use that too for the homepage check.
Ideally one would introduce the "using: :homebrew_curl" stanza for the homepage
line in the DSL, but it is easier to implicitely use the same logic
for homepages and url's and define the "using:" only once.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

If the download url is using brewed curl, use that too for the homepage check.
Ideally one would introduce the "using: :homebrew_curl" stanza for the homepage
line in the DSL, but it is easier to implicitely use the same logic
for homepages and url's and define the "using:" only once.
@BrewTestBot
Copy link
Member

Review period will end on 2021-08-23 at 08:17:57 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 20, 2021
@iMichka iMichka added the critical Critical change which should be shipped as soon as possible. label Aug 21, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 21, 2021
@iMichka iMichka merged commit d14fc2d into Homebrew:master Aug 21, 2021
@iMichka iMichka deleted the homepage branch August 21, 2021 16:37
@MikeMcQuaid
Copy link
Member

Seems like a bit of a hack but I'm happy with this to unblock us for now. We'll probably need to eventually handle the "it's needed for homepage but not download URL" case but that can wait for now.

@github-actions github-actions bot added the outdated PR was locked due to age label Sep 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants