Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: gitlab prerelease check keep time/zone #11920

Merged
merged 1 commit into from Sep 7, 2021

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Aug 25, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Not sure if this check does anything with change, or if it is a no-op.

The existing check has a problem where CI runner timezone can impact behavior of prerelease output. Date.parse will ignore the time/timezone and parse the date portion.

For example, Homebrew/homebrew-core#83805

@BrewTestBot
Copy link
Member

Review period will end on 2021-08-26 at 03:13:25 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 25, 2021
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 26, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@cho-m
Copy link
Member Author

cho-m commented Sep 6, 2021

I think this should be ready to merge.

Not sure if possible to add test coverage. At least, the Ruby logic seems to work with arbitrary timestamps/timezones compared to original.

@MikeMcQuaid MikeMcQuaid merged commit 8bac985 into Homebrew:master Sep 7, 2021
@MikeMcQuaid
Copy link
Member

Thanks again @cho-m!

@cho-m cho-m deleted the gitlab-released-at-keep-time branch September 7, 2021 13:47
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants