Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade: add --fetch-before-install switch #11935

Closed
wants to merge 1 commit into from

Conversation

FnControlOption
Copy link
Contributor

@FnControlOption FnControlOption commented Aug 27, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Not implemented:

  • Fetch source if unbottled
  • --force-bottle
  • --build-from-source
  • Casks

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the intent of this PR but:

  • this should the default behaviour
  • should be already fetching before installation. Why is this not working as we want/expect? Perhaps it's this method that needs to be called earlier. It will also handle those that are built from source.

@FnControlOption
Copy link
Contributor Author

Please see #11940

@github-actions github-actions bot added the outdated PR was locked due to age label Sep 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants