Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew.sh: set HOMEBREW_FORCE_HOMEBREW_ON_LINUX when core repo is homeb… #11938

Merged
merged 1 commit into from Sep 1, 2021

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Aug 29, 2021

…rew-core

See Homebrew/install#571

When the install script sets as https://github.com/Homebrew/homebrew-core,
we need to use the homebrew-core bottle domain, and correctly set
the HOMEBREW_CORE_DEFAULT_GIT_REMOTE below.

This also fixes the brew doctor issue for new homebrew-core Linux installations

Warning: Suspicious https://github.com/Homebrew/linuxbrew-core git origin remote found.
The current git origin is:
https://github.com/Homebrew/homebrew-core

With a non-standard origin, Homebrew won't update properly.
You can solve this by setting the origin remote:
git -C "/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-core" remote set-url origin https://github.com/Homebrew/linuxbrew-core

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@BrewTestBot
Copy link
Member

Review period will end on 2021-08-31 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 29, 2021
@iMichka iMichka requested a review from carlocab August 29, 2021 19:44
Library/Homebrew/brew.sh Outdated Show resolved Hide resolved
@iMichka iMichka force-pushed the domain branch 2 times, most recently from 79cd92c to 80643cc Compare August 29, 2021 20:00
@iMichka iMichka requested a review from dawidd6 August 29, 2021 20:04
Library/Homebrew/brew.sh Outdated Show resolved Hide resolved
@iMichka iMichka force-pushed the domain branch 2 times, most recently from 4759ef9 to 5ba9c8d Compare August 29, 2021 20:11
@Bo98
Copy link
Member

Bo98 commented Aug 30, 2021

The check here would also need adjusting:

@full_name = "Homebrew/linuxbrew-core" unless Homebrew::EnvConfig.force_homebrew_on_linux?

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 31, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@MikeMcQuaid
Copy link
Member

Looks good once @Bo98's comment is addressed.

@iMichka iMichka force-pushed the domain branch 3 times, most recently from d2cc74b to 09e72db Compare August 31, 2021 19:42
…o is homebrew-core

See Homebrew/install#571

When the install script sets as https://github.com/Homebrew/homebrew-core,
we need to use the homebrew-core bottle domain, and correctly set
the HOMEBREW_CORE_DEFAULT_GIT_REMOTE below.

This also fixes the brew doctor issue for new homebrew-core Linux installations

Warning: Suspicious https://github.com/Homebrew/linuxbrew-core git origin remote found.
The current git origin is:
  https://github.com/Homebrew/homebrew-core

With a non-standard origin, Homebrew won't update properly.
You can solve this by setting the origin remote:
  git -C "/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-core" remote set-url origin https://github.com/Homebrew/linuxbrew-core
@MikeMcQuaid MikeMcQuaid merged commit 364096b into Homebrew:master Sep 1, 2021
@MikeMcQuaid
Copy link
Member

Thanks again @iMichka!

@github-actions github-actions bot added the outdated PR was locked due to age label Oct 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants