New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
brew.sh: set HOMEBREW_FORCE_HOMEBREW_ON_LINUX when core repo is homeb… #11938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review period will end on 2021-08-31 at 00:00:00 UTC. |
BrewTestBot
added
the
waiting for feedback
Merging is blocked until sufficient time has passed for review
label
Aug 29, 2021
dawidd6
reviewed
Aug 29, 2021
iMichka
force-pushed
the
domain
branch
2 times, most recently
from
August 29, 2021 20:00
79cd92c
to
80643cc
Compare
dawidd6
reviewed
Aug 29, 2021
iMichka
force-pushed
the
domain
branch
2 times, most recently
from
August 29, 2021 20:11
4759ef9
to
5ba9c8d
Compare
dawidd6
approved these changes
Aug 29, 2021
MikeMcQuaid
reviewed
Aug 30, 2021
The check here would also need adjusting:
|
BrewTestBot
removed
the
waiting for feedback
Merging is blocked until sufficient time has passed for review
label
Aug 31, 2021
Review period ended. |
BrewTestBot
approved these changes
Aug 31, 2021
MikeMcQuaid
approved these changes
Aug 31, 2021
Looks good once @Bo98's comment is addressed. |
iMichka
force-pushed
the
domain
branch
3 times, most recently
from
August 31, 2021 19:42
d2cc74b
to
09e72db
Compare
…o is homebrew-core See Homebrew/install#571 When the install script sets as https://github.com/Homebrew/homebrew-core, we need to use the homebrew-core bottle domain, and correctly set the HOMEBREW_CORE_DEFAULT_GIT_REMOTE below. This also fixes the brew doctor issue for new homebrew-core Linux installations Warning: Suspicious https://github.com/Homebrew/linuxbrew-core git origin remote found. The current git origin is: https://github.com/Homebrew/homebrew-core With a non-standard origin, Homebrew won't update properly. You can solve this by setting the origin remote: git -C "/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-core" remote set-url origin https://github.com/Homebrew/linuxbrew-core
dawidd6
approved these changes
Aug 31, 2021
MikeMcQuaid
approved these changes
Sep 1, 2021
Thanks again @iMichka! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rew-core
See Homebrew/install#571
When the install script sets as https://github.com/Homebrew/homebrew-core,
we need to use the homebrew-core bottle domain, and correctly set
the HOMEBREW_CORE_DEFAULT_GIT_REMOTE below.
This also fixes the brew doctor issue for new homebrew-core Linux installations
Warning: Suspicious https://github.com/Homebrew/linuxbrew-core git origin remote found.
The current git origin is:
https://github.com/Homebrew/homebrew-core
With a non-standard origin, Homebrew won't update properly.
You can solve this by setting the origin remote:
git -C "/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-core" remote set-url origin https://github.com/Homebrew/linuxbrew-core
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?