Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sandbox: fallback to tput for winsize #11954

Merged
merged 1 commit into from Sep 1, 2021
Merged

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Sep 1, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This should improve compatibility with some tests sensitive to the terminal size in the non-tty (CI) environment, such as oakc.

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Sep 1, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine to me but can we get some more extensive comments in here as to:

  • what is happening here
  • why this is being done
  • how this is being done

@Bo98
Copy link
Member Author

Bo98 commented Sep 1, 2021

Have a look at the latest commit and see if the comments make sense.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! When you can be bothered (in a follow-up PR) I'd love to see similar level of comments on the other surrounding code around this security feature. ❤️

@Bo98 Bo98 merged commit fb8d679 into Homebrew:master Sep 1, 2021
@Bo98 Bo98 deleted the sandbox-tput branch September 1, 2021 20:34
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants