brew list shows cask without option #12003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
reviewed
Sep 8, 2021
MikeMcQuaid
reviewed
Sep 8, 2021
Rylan12
reviewed
Sep 8, 2021
|
@hyuraku If I'm correct and |
cnnrmnn
approved these changes
Sep 10, 2021
There was a problem hiding this comment.
Change to to_formulae_to_casks looks fine to me! Might be worth thinking about reorganizing that family of methods in the future. Is a bit strange that methods meant to return formulae and casks will return kegs if given some methods and formulae if given others.
Rylan12
reviewed
Sep 11, 2021
Library/Homebrew/cmd/list.rb
Outdated
| @@ -132,7 +132,10 @@ def list | |||
| system_command! "find", args: args.named.to_default_kegs.map(&:to_s) + %w[-not -type d -print], | |||
| print_stdout: true | |||
| else | |||
| args.named.to_default_kegs.each { |keg| PrettyListing.new keg } | |||
| formula_names, cask_names = args.named.to_formulae_to_casks(method: :default_kegs) | |||
There was a problem hiding this comment.
Suggested change
| formula_names, cask_names = args.named.to_formulae_to_casks(method: :default_kegs) | |
| kegs, casks = args.named.to_formulae_to_casks(method: :default_kegs) |
Library/Homebrew/cmd/list.rb
Outdated
| args.named.to_default_kegs.each { |keg| PrettyListing.new keg } | ||
| formula_names, cask_names = args.named.to_formulae_to_casks(method: :default_kegs) | ||
|
|
||
| formula_names.each { |keg| PrettyListing.new keg } if formula_names.present? |
There was a problem hiding this comment.
Suggested change
| formula_names.each { |keg| PrettyListing.new keg } if formula_names.present? | |
| kegs.each { |keg| PrettyListing.new keg } if kegs.present? |
Rylan12
approved these changes
Sep 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?solve #11983