install, upgrade: recompute dependencies before installation #12004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
reviewed
Sep 8, 2021
| @@ -358,7 +358,7 @@ def install | |||
| raise UnbottledError, [formula] if !pour_bottle? && !formula.bottle_unneeded? && !DevelopmentTools.installed? | |||
|
|
|||
| unless ignore_deps? | |||
| deps = compute_dependencies | |||
| deps = compute_dependencies(force: true) | |||
There was a problem hiding this comment.
Suggested change
| deps = compute_dependencies(force: true) | |
| deps = compute_dependencies(use_cache: false) |
Comment on lines
478
to
479
| def compute_dependencies(force: false) | ||
| @compute_dependencies = nil if force |
There was a problem hiding this comment.
Suggested change
| def compute_dependencies(force: false) | |
| @compute_dependencies = nil if force | |
| def compute_dependencies(use_cache: true) | |
| @compute_dependencies = nil unless use_cache |
FnControlOption
force-pushed
the
upgrade-fix
branch
from
536eebe
to
06041f7
Compare
MikeMcQuaid
approved these changes
Sep 8, 2021
|
Thanks again @FnControlOption! |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Fix for #11989
#11940 and #11963 cause the method
compute_dependenciesto be invoked before any formulae have been installed, so dependencies must be recomputed at installation.