Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install, upgrade: don't print message if formula already installed #12015

Merged
merged 1 commit into from Sep 10, 2021

Conversation

FnControlOption
Copy link
Contributor

@FnControlOption FnControlOption commented Sep 9, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fix for #11900

The prelude method checks if the formula has already been installed, so it should be invoked before printing any install or upgrade messages.

@MikeMcQuaid
Copy link
Member

Thanks again @FnControlOption!

@MikeMcQuaid MikeMcQuaid merged commit 1aae34d into Homebrew:master Sep 10, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants