Add process_type to service DSL #12019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables mpd to be run with the "Interactive" value, which avoids performance issues such as skipping when playing music. See this PR, where this was done previously: Homebrew/homebrew-core#19410 The ProcessType plist key was lost in the conversion to the service DSL: Homebrew/homebrew-core@483ad1f
SMillerDev
approved these changes
Sep 10, 2021
Rylan12
approved these changes
Sep 11, 2021
There was a problem hiding this comment.
Looks good to me!
I don't know enough about systemd but given Sean's approval I think this is good to merge. Thanks so much for your first Homebrew contribution, @valrus!
Not specific to this PR but is it intentional that calling .service.keep_alive (and .working_dir, .process_type, and all of those) return nil? I'd expect them to return the value they've been set to (that's probably a question for @SMillerDev)
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables services to be run with the "Interactive"
ProcessTypevalue; in particular, this avoids performance issues such as skipping when playing music inmpd. See this previous PR, which addedProcessTypefor the oldplistmethod:Homebrew/homebrew-core#19410
The
ProcessTypeplist key was lost in the conversion to the service DSL,so this is just reinstating it:
Homebrew/homebrew-core@483ad1f
I was experiencing music skipping in
mpdand confirmed that adding the "Interactive"ProcessTypein a custom plist resolved it.The possible values are as described in the launchd manpage. I didn't see any analogous options for
systemdso there it's a no-op.If and when this is merged I can submit a second PR to use it for the
mpdformula.