Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-cmd/extract: remove old DependencyCollector::Compat handling #12036

Merged
merged 1 commit into from Sep 14, 2021

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Sep 10, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This was needed as a temporary measure due to some dependency-related deprecation. DependencyCollector::Compat no longer exists so this monkey patch is never invoked and can be removed.

@BrewTestBot
Copy link
Member

Review period will end on 2021-09-13 at 23:20:50 UTC.

@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Sep 10, 2021
@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Sep 11, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 14, 2021
@MikeMcQuaid MikeMcQuaid merged commit 6139e36 into Homebrew:master Sep 14, 2021
@Bo98 Bo98 deleted the extract-compat branch September 14, 2021 10:06
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants