New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump: add --start-with
option to retrieve a subset of results
#12121
Conversation
cb6aae1
to
1a8dd7d
Compare
Review period will end on 2021-09-28 at 00:00:00 UTC. |
1a8dd7d
to
3876926
Compare
Code looks good!
What about something like |
3876926
to
d1c257b
Compare
--initial
option to retrieve a subset of results--start-with
option to retrieve a subset of results
Review period ended. |
Both of the repology.org servers appear to again be TLS 1.3-only, which macOS's shipping
|
@EricFromCanada oh no! I think reasonable to make |
d1c257b
to
6176bc3
Compare
It's now working after making use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good once tests are fixed!
Library/Homebrew/dev-cmd/bump.rb
Outdated
@@ -53,6 +55,8 @@ def bump | |||
|
|||
limit = args.limit.to_i if args.limit.present? | |||
|
|||
opoo "Homebrew-installed `curl` is required for Repology queries" unless Formula["curl"].any_version_installed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to handle curl
formula not existing.
6176bc3
to
d9758b8
Compare
Another thought: it might be useful if, when run without specifying a list of packages, the command only checked for open pull requests if the current version does not match the livecheck version. |
64189ea
to
0299703
Compare
Currently stuck on how to get |
I wonder if we can do something like install a |
6dbec1e
to
a40f148
Compare
My current workaround is to add the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻. Would be good to install curl
as part of the GitHub Actions tests to avoid the skip warning.
a40f148
to
af53aad
Compare
af53aad
to
46335bb
Compare
Plus a few fixes for output.
46335bb
to
811d0fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, nice work as usual @EricFromCanada!
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Re-enables the Repology methods disabled in #11624 since they appear to be working again. Also implements the following for
brew bump
:--start-with
which, when passed a letter or word, fetches results that follow that term (inclusive)--limit
showing one more result than requestedcurl
to ensure TLS 1.3 supportSample output: