Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/triage: fixes for github-script@v5 #12125

Merged
merged 1 commit into from Sep 26, 2021
Merged

workflows/triage: fixes for github-script@v5 #12125

merged 1 commit into from Sep 26, 2021

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Sep 26, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Broke after #12119.

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Sep 26, 2021
@Bo98
Copy link
Member Author

Bo98 commented Sep 26, 2021

This of course doesn't fix it failing on this PR as it only works after this is merged. Bit of a blind game.

@dawidd6
Copy link
Member

dawidd6 commented Sep 26, 2021

And we can't merge this because the required check is failing...

@Bo98
Copy link
Member Author

Bo98 commented Sep 26, 2021

Temporarily lifted the "include admins" restriction so we can merge.

@Bo98 Bo98 merged commit 0e04c96 into master Sep 26, 2021
@Bo98 Bo98 deleted the triage-fix branch September 26, 2021 20:40
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants