Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocops/urls: allow plain HTTP mirrors #12165

Merged
merged 1 commit into from Oct 2, 2021
Merged

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Oct 1, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

For the sources which we mandate HTTPS for, allow a plain HTTP mirror to be used, as long as the HTTPS version is present and is higher in the mirror list.

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Oct 1, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@Bo98 Bo98 merged commit 1909d89 into Homebrew:master Oct 2, 2021
@Bo98 Bo98 deleted the http-mirror branch October 2, 2021 00:36
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants