Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

download_strategy: adjust --insecure warning wording #12182

Merged
merged 1 commit into from Oct 4, 2021
Merged

download_strategy: adjust --insecure warning wording #12182

merged 1 commit into from Oct 4, 2021

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Oct 4, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

#12172 (review)

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Oct 4, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@Bo98 Bo98 mentioned this pull request Oct 4, 2021
Merged
7 tasks
Rylan12
Rylan12 approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thought, but I think this is great

Library/Homebrew/download_strategy.rb Outdated Show resolved Hide resolved
@Bo98 @Rylan12
download_strategy: adjust --insecure warning wording
5137244 
Co-authored-by: Rylan Polster <rslpolster@gmail.com>
Rylan12
Rylan12 approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @Bo98!

@Bo98 Bo98 enabled auto-merge October 4, 2021 19:14
@Bo98 Bo98 merged commit 7d0d2dd into Homebrew:master Oct 4, 2021
@MikeMcQuaid
Copy link
Member

@Bo98 Good update 👏🏻

@Bo98 Bo98 deleted the ds-wording branch October 5, 2021 11:58
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@Rylan12 Rylan12 Rylan12 approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Bo98 @BrewTestBot @MikeMcQuaid @Rylan12