Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils/shfmt.sh: success with auto-fixable changes on brew style --fix #12205

Merged
merged 3 commits into from Oct 7, 2021

Conversation

XuehaiPan
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Resolve #12072 (comment).

brew style --fix will not fail on auto-fixable changes and will apply them silently (show single prompt but don't show the long differences).

Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @XuehaiPan!

@MikeMcQuaid MikeMcQuaid merged commit 9aa7746 into Homebrew:master Oct 7, 2021
@XuehaiPan XuehaiPan deleted the style-shfmt-retcode branch October 7, 2021 14:49
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants