Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/mac: bump latest_sdk_version #12218

Merged
merged 2 commits into from Oct 12, 2021
Merged

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The newest macOS SDK version is 11.3.

The newest macOS SDK version is 11.3.
@carlocab carlocab requested a review from Bo98 October 10, 2021 06:30
@BrewTestBot
Copy link
Member

Review period will end on 2021-10-12 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Oct 10, 2021
@Bo98
Copy link
Member

Bo98 commented Oct 10, 2021

Not sure if we really want/need to track minor versions. What was added/changed in the 11.1 and 11.3 SDKs that we use?

Might be better to just make this track major versions (11).

@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Oct 10, 2021
@MikeMcQuaid
Copy link
Member

Not sure if we really want/need to track minor versions. What was added/changed in the 11.1 and 11.3 SDKs that we use?

Might be better to just make this track major versions (11).

👍🏻 from me, might want to add a comment to make that clear too.

@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Oct 11, 2021
@carlocab
Copy link
Member Author

Not sure if we really want/need to track minor versions. What was added/changed in the 11.1 and 11.3 SDKs that we use?

I didn't check. I just saw a TODO, and I did it 🙂

Might be better to just make this track major versions (11).

Sure, fine with me.

@Bo98
Copy link
Member

Bo98 commented Oct 11, 2021

I imagine 11.1 is a relic from where we did briefly follow minor versions. Now we use MacOSX11.sdk and don't care about anything more specific than that.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Oct 12, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@carlocab carlocab merged commit bddcc08 into Homebrew:master Oct 12, 2021
@carlocab carlocab deleted the latest-sdk-version branch October 12, 2021 03:09
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants