Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tap: fix unexpected wrong variable name #12226

Merged
merged 1 commit into from Oct 12, 2021
Merged

Conversation

XuehaiPan
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid I found an unintended error added by my code completion engine in PR #12221. Should we add new tests for custom remotes in CI tests?

@MikeMcQuaid
Copy link
Member

Whoops! Thanks again @XuehaiPan!

@MikeMcQuaid MikeMcQuaid merged commit 20d1c82 into Homebrew:master Oct 12, 2021
@XuehaiPan XuehaiPan deleted the tap-fix branch October 13, 2021 06:06
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants