Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tap: handle TapCoreRemoteMismatchError when tapping the core tap without a URL #12233

Merged
merged 1 commit into from Oct 13, 2021

Conversation

XuehaiPan
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Handle TapCoreRemoteMismatchError on brew tap homebrew/core without a URL while HOMEBREW_CORE_GIT_REMOTE set.

$ rm -rf "$(brew --repo homebrew/core)"

$ export HOMEBREW_CORE_GIT_REMOTE="https://mirrors.tuna.tsinghua.edu.cn/git/homebrew/linuxbrew-core.git"

$ brew tap homebrew/core  # tap without a URL while `HOMEBREW_CORE_GIT_REMOTE` set
Updating Homebrew...
Error: Tap homebrew/core remote does mot match HOMEBREW_CORE_GIT_REMOTE.
https://mirrors.tuna.tsinghua.edu.cn/git/homebrew/linuxbrew-core.git != https://github.com/Homebrew/linuxbrew-core
Please set HOMEBREW_CORE_GIT_REMOTE="https://github.com/Homebrew/linuxbrew-core" and run `brew update` instead.
Error: Failure while executing; `/home/PanXuehai/Projects/brew/bin/brew tap homebrew/core` exited with 1.
Error: Tap homebrew/core remote does mot match HOMEBREW_CORE_GIT_REMOTE.
https://mirrors.tuna.tsinghua.edu.cn/git/homebrew/linuxbrew-core.git != https://github.com/Homebrew/linuxbrew-core
Please set HOMEBREW_CORE_GIT_REMOTE="https://github.com/Homebrew/linuxbrew-core" and run `brew update` instead.

@MikeMcQuaid MikeMcQuaid merged commit d93d19a into Homebrew:master Oct 13, 2021
@XuehaiPan XuehaiPan deleted the core-tap-mismatch branch October 13, 2021 12:41
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants