Apache: Extend URL_MATCH_REGEX

[samford]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

apache-pulsar is the only formula in homebrew/core using an Apache URL that doesn't follow the prevailing /dyn/closer.lua?path=... format. The Apache strategy doesn't match the formula's current stable URL (https://www.apache.org/dyn/mirrors/mirrors.cgi?action=download&filename=pulsar/pulsar-2.8.0/apache-pulsar-2.8.0-src.tar.gz) and livecheck ends up checking the Git tags from head instead. We prefer to align the check with the stable URL whenever possible, so it's appropriate to extend the Apache strategy to address this.

It's been suggested in Homebrew/homebrew-core#87587 that we should simply update the URL to use the prevailing format (i.e., https://www.apache.org/dyn/closer.lua?path=pulsar/pulsar-2.8.0/apache-pulsar-2.8.0-src.tar.gz does work). However, the first-party download page uses the mirrors.cgi URL, so it's possible for the URL to switch back to the format that the Apache strategy doesn't support (e.g., if someone copies the URL from the page and uses it in a version bump).

We could potentially add an audit to enforce the closer.lua URL format for Apache URLs but I think there's value in extending the Apache strategy to support the mirrors.cgi URL format regardless.

[BrewTestBot]

Review period will end on 2021-10-20 at 15:56:31 UTC.

[MikeMcQuaid]

We could potentially add an audit to enforce the closer.lua URL format for Apache URLs but I think there's value in extending the Apache strategy to support the mirrors.cgi URL format regardless.

I'd prefer this personally but don't feel super strongly.

[MikeMcQuaid]

Approving as the actual change is very minimal.

[samford]

We could potentially add an audit to enforce the closer.lua URL format for Apache URLs but I think there's value in extending the Apache strategy to support the mirrors.cgi URL format regardless.

I'd prefer this personally but don't feel super strongly.

We can add the audit in addition to extending the Apache strategy, so it makes sense to me. I'll go ahead and update the URL in the related homebrew/core PR and work on a separate brew PR for the URL audit.

[MikeMcQuaid]

We can add the audit in addition to extending the Apache strategy, so it makes sense to me. I'll go ahead and update the URL in the related homebrew/core PR and work on a separate brew PR for the URL audit.

I think it's fine to leave as-is after seeing this change, actually 👍🏻

[samford]

The latest push only includes a small tweak, to place path before filename in the regex group (i.e., (?:path|filename)). path is the parameter found in the overwhelming majority of our Apache URLs, so putting it at the front of the group could perform infinitesimally better over a large number of executions (e.g., checking a large tap like homebrew/core). It's not very meaningful but there's no harm in it, as the regex continues to match the same URLs.

[BrewTestBot]

Review period ended.