Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix brew untap with HOMEBREW_INSTALL_FROM_API #12346

Merged
merged 1 commit into from Oct 29, 2021
Merged

Fix brew untap with HOMEBREW_INSTALL_FROM_API #12346

merged 1 commit into from Oct 29, 2021

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Oct 28, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

brew untap will complain if its run on a tap that has formulae/casks installed, so homebrew/core and homebrew/cask weren't able to be uninstalled with brew untap even with HOMEBREW_INSTALL_FROM_API set. This PR doesn't check for installed formulae/casks for homebrew/core and homebrew/cask with HOMEBREW_INSTALL_FROM_API set.

See Homebrew/discussions#2365 (comment)

@Rylan12 Rylan12 added the critical Critical change which should be shipped as soon as possible. label Oct 28, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

MikeMcQuaid
MikeMcQuaid approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style suggestion but fine as-is.

@Rylan12 Rylan12 merged commit dae9a34 into Homebrew:master Oct 29, 2021
@Rylan12 Rylan12 deleted the fix-untap-with-install-from-api branch October 29, 2021 17:27
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Rylan12 @BrewTestBot @MikeMcQuaid @carlocab