Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix brew doctor with HOMEBREW_INSTALL_FROM_API #12358

Merged
merged 2 commits into from Oct 31, 2021

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Oct 31, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes #12356

I could have sworn I fixed this in #12333 but I must have made some change and forgotten to test it out fully. Either way, this should fix the check_deleted_formulae check in brew doctor so that if HOMEBREW_INSTALL_FROM_API is set, kegs with their tap set to homebrew/core and kegs with a blank tap but which are available via the API won't be listed as being deleted.

This also raised another interesting issue which is that installing with HOMEBREW_INSTALL_FROM_API (when homebrew/core isn't tapped) leaves the tap entry in INSTALL_RECEIPT.json blank. This should probably be changed to be homebrew/core. However, since people have been using it, it's probably too late to not have the blank tap condition here.

I'm way too tired to think this through completely right now, though, so I'll just leave this as-is and maybe re-visit in the morning.

@Rylan12 Rylan12 added the critical Critical change which should be shipped as soon as possible. label Oct 31, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

Co-authored-by: Bo Anderson <mail@boanderson.me>
@Rylan12 Rylan12 merged commit 67cc374 into Homebrew:master Oct 31, 2021
@Rylan12 Rylan12 deleted the install-from-api-doctor branch October 31, 2021 20:58
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 1, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brew doctor doesn't work with HOMEBREW_INSTALL_FROM_API and untap homebrew/core
3 participants