Fix brew doctor
with HOMEBREW_INSTALL_FROM_API
#12358
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Fixes #12356
I could have sworn I fixed this in #12333 but I must have made some change and forgotten to test it out fully. Either way, this should fix the
check_deleted_formulae
check inbrew doctor
so that ifHOMEBREW_INSTALL_FROM_API
is set, kegs with their tap set tohomebrew/core
and kegs with a blank tap but which are available via the API won't be listed as being deleted.This also raised another interesting issue which is that installing with
HOMEBREW_INSTALL_FROM_API
(whenhomebrew/core
isn't tapped) leaves thetap
entry inINSTALL_RECEIPT.json
blank. This should probably be changed to behomebrew/core
. However, since people have been using it, it's probably too late to not have the blank tap condition here.I'm way too tired to think this through completely right now, though, so I'll just leave this as-is and maybe re-visit in the morning.