Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-cmd/bottle: don't gen all bottles if a bottle spec already exists #12384

Merged
merged 1 commit into from Nov 6, 2021

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Nov 5, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Hopefully fixes the issue seen in Homebrew/homebrew-core@d42d3a9.

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Nov 5, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@Bo98 Bo98 merged commit f014526 into Homebrew:master Nov 6, 2021
@Bo98 Bo98 deleted the bottle-all-keep-old branch November 6, 2021 03:00
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants