Do not pass -Wl,-headerpad_max_install_names on linux

[evanphx]

One of the more curious bugs, if you use -Wl,-headerpad_max_install_names on linux, it tries to link a library named eaderpath_max_install_names in, which causes all kinds of weird havoc.

Most notably, gtester inside glib fails to run for bizarre reasons. -Wl,-headerpad_max_install_names is not an option anywhere outside macos anyway, so move it to macos only and avoid the heartache of extremely weird bugs.

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

[Bo98]

This change makes sense. Though what confuses me is how no one has ever reported the issue you have described. The code has been there for years.

[evanphx]

@Bo98 you and me both. My theory is that it's only in std and maybe linux isn't using std by default? I'm using homebrew in a bit more exotic way atm and thusly might have just stumbled into a dusty corner!

[Bo98]

My theory is that it's only in std and maybe linux isn't using std by default?

Yes we only use std by default in formula test blocks (on all platforms - even macOS). Formulae can use env :std to use that environment during the build stage, but that's strongly discouraged and is in fact outright forbidden in homebrew-core. I think this shows how little people use that (though I suppose most taps are macOS only).

I still expected it to have popped up at least once in a test but it seems not.