Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service: add basic cron support #12462

Merged
merged 1 commit into from Nov 30, 2021

Conversation

SMillerDev
Copy link
Member

@SMillerDev SMillerDev commented Nov 21, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This adds basic cron support, allowing parts of a cron statement to be either a number or *. After this all service run types are implemented.

@BrewTestBot
Copy link
Member

Review period will end on 2021-11-23 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Nov 21, 2021
@SMillerDev SMillerDev changed the title service: add cron support service: add basic cron support Nov 21, 2021
@SMillerDev
Copy link
Member Author

Builds on the functions added in #12460

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Nov 21, 2021
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Do we expect to support launchd cron equivalents?

@SMillerDev
Copy link
Member Author

https://github.com/Homebrew/brew/pull/12462/files#diff-752349017cbb1770eaf117fc518cbf68da64120fa1e62db02225cbfb95881c26R306 is the only thing that's needed for basic launchd support. Things like ranges and repeated entries will have to wait for the more complicated support.

@MikeMcQuaid
Copy link
Member

@SMillerDev Great, thanks!

@BrewTestBot
Copy link
Member

Review period ended.

@SMillerDev SMillerDev merged commit a285ef6 into Homebrew:master Nov 30, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 31, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2021
@SMillerDev SMillerDev deleted the feature/service/cron branch September 21, 2022 13:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants