New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service: add basic cron support #12462
Conversation
caaaa73
to
cc4e76f
Compare
Review period will end on 2021-11-23 at 00:00:00 UTC. |
cc4e76f
to
0388211
Compare
Builds on the functions added in #12460 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. Do we expect to support launchd
cron equivalents?
https://github.com/Homebrew/brew/pull/12462/files#diff-752349017cbb1770eaf117fc518cbf68da64120fa1e62db02225cbfb95881c26R306 is the only thing that's needed for basic launchd support. Things like ranges and repeated entries will have to wait for the more complicated support. |
@SMillerDev Great, thanks! |
0388211
to
34636a0
Compare
Review period ended. |
34636a0
to
3029758
Compare
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This adds basic cron support, allowing parts of a cron statement to be either a number or
*
. After this all service run types are implemented.