Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils: add method ensure_formula_installed! #12469

Merged
merged 8 commits into from Nov 23, 2021
Merged

utils: add method ensure_formula_installed! #12469

merged 8 commits into from Nov 23, 2021

Conversation

XuehaiPan
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Reusing common functions, see #12465 (comment) and #12465 (comment).

New tests need?

MikeMcQuaid
MikeMcQuaid reviewed Nov 23, 2021
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far!

Library/Homebrew/github_packages.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils.rb Outdated Show resolved Hide resolved
MikeMcQuaid
MikeMcQuaid reviewed Nov 23, 2021
View reviewed changes
Library/Homebrew/utils.rb Outdated Show resolved Hide resolved
Library/Homebrew/style.rb Outdated Show resolved Hide resolved
MikeMcQuaid
MikeMcQuaid approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tiny suggestions but: this is great, wonderful work @XuehaiPan!

Library/Homebrew/cmd/update-report.rb Outdated Show resolved Hide resolved
Library/Homebrew/style.rb Outdated Show resolved Hide resolved
Library/Homebrew/style.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils.rb Outdated Show resolved Hide resolved
@XuehaiPan @MikeMcQuaid
Apply suggestions from code review
62a6306 
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Signed-off-by: XuehaiPan <XuehaiPan@pku.edu.cn>
@MikeMcQuaid
Copy link
Member

Thanks again @XuehaiPan!

@MikeMcQuaid MikeMcQuaid merged commit 7c4247e into Homebrew:master Nov 23, 2021
@XuehaiPan XuehaiPan deleted the ensure-installed branch November 23, 2021 17:34
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 24, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XuehaiPan @MikeMcQuaid