Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug.yml: fix missing label property #12502

Merged
merged 1 commit into from Dec 1, 2021
Merged

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Dec 1, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Submitting bug reports hasn't worked for a while because of the missing
label.

My editor complained about labels needing to be an array, so I've made
that one too. It was also complaining about the missing label property
for the checkboxes, so I guess it knows what it's talking about here.

See Homebrew/discussions#2526 (comment)

Submitting bug reports hasn't worked for a while because of the missing
`label`.

My editor complained about `labels` needing to be an array, so I've made
that one too. It was also complaining about the missing label property
for the checkboxes, so I guess it knows what it's talking about here.
@carlocab carlocab added the critical Critical change which should be shipped as soon as possible. label Dec 1, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@carlocab carlocab merged commit be908f6 into Homebrew:master Dec 1, 2021
@carlocab carlocab deleted the bug-template branch December 1, 2021 21:33
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants