Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linuxbrew-core migration not applying to Linuxbrew/homebrew-core #12551

Merged
merged 1 commit into from Dec 12, 2021

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Dec 11, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

There's an even older remote we used, Linuxbrew/homebrew-core, which redirects to Homebrew/linuxbrew-core. Some users who installed a long time ago may still have Linuxbrew/homebrew-core as a git origin as we never migrated them to Homebrew/linuxbrew-core and simply relied on GitHub's redirect feature. Those users simply faced their linuxbrew-core install no longer receiving updates when we should have been migrating them.

See Homebrew/discussions#2624.

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Dec 11, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@iMichka iMichka merged commit 3f0b412 into Homebrew:master Dec 12, 2021
@MikeMcQuaid
Copy link
Member

Makes sense, nice work @Bo98!

@Bo98 Bo98 deleted the linuxbrew-homebrew-core branch December 13, 2021 16:45
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants