Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add latest CPUs #12587

Merged
merged 3 commits into from Dec 22, 2021
Merged

Add latest CPUs #12587

merged 3 commits into from Dec 22, 2021

Conversation

fxcoudert
Copy link
Member

Taken from the latest version of the mach/machine.h header

@BrewTestBot
Copy link
Member

Review period will end on 2021-12-21 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 18, 2021
@Bo98
Copy link
Member

Bo98 commented Dec 19, 2021

Should be added here too: https://github.com/Homebrew/brew/blob/master/Library/Homebrew/test/hardware/cpu_spec.rb#L23

so the tests pass when run on those systems.

@MikeMcQuaid
Copy link
Member

Should be added here too: https://github.com/Homebrew/brew/blob/master/Library/Homebrew/test/hardware/cpu_spec.rb#L23

so the tests pass when run on those systems.

Ideally we don't duplicate this list in both places.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 21, 2021
@BrewTestBot
Copy link
Member

Review period ended.

carlocab
carlocab reviewed Dec 21, 2021
View reviewed changes
Library/Homebrew/extend/os/mac/hardware/cpu.rb Outdated
@@ -107,6 +107,8 @@ def arm_family
:arm_lightning_thunder
when 0x573b5eec, 0x1b588bb3 # ARMv8.4-A (Firestorm, Icestorm)
:arm_firestorm_icestorm
when 0xda33d83d # ARMv8.4-A (Blizzard, Avalanche)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Apple A15 is actually ARMv8.5-A.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any hard info? The only info I found is this WP page, which states otherwise: https://en.wikipedia.org/wiki/Comparison_of_ARMv8-A_cores

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing official, but:

https://nanoreview.net/en/soc/apple-a15-bionic
https://www.headshotreviews.com/apple-a15-bionic-chip-apl1w05-specification/
https://screenrant.com/snapdragon-8-gen-1-vs-a15-bionic-qualcomm-apple-chips-compared/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, then. I've updated the PR

@fxcoudert fxcoudert merged commit 2c57a98 into master Dec 22, 2021
@fxcoudert fxcoudert deleted the fxcoudert-patch-1-1 branch December 22, 2021 16:03
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fxcoudert @BrewTestBot @Bo98 @MikeMcQuaid @carlocab