Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove on_os from formula #12590

Merged
merged 1 commit into from Dec 21, 2021

Conversation

hyuraku
Copy link
Contributor

@hyuraku hyuraku commented Dec 20, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

remove os_os methods from formula.rb because of # TODO

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch again @hyuraku!

@MikeMcQuaid MikeMcQuaid merged commit 22f295a into Homebrew:master Dec 21, 2021
@carlocab
Copy link
Member

carlocab commented Dec 21, 2021

This is causing post_install and brew bottle failures. #12615

@github-actions github-actions bot added the outdated PR was locked due to age label Jan 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants