Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postinstall: allow write access to cellars in repository. #1261

Merged
merged 1 commit into from
Oct 12, 2016
Merged

postinstall: allow write access to cellars in repository. #1261

merged 1 commit into from
Oct 12, 2016

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Oct 11, 2016 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

If HOMEBREW_CELLAR (or HOMEBREW_PREFIX) are children of HOMEBREW_REPOSITORY it’s important to deny write to the repository and enable write to the Cellar/prefix afterwards CC @tdsmith

@MikeMcQuaid
postinstall: allow write access to cellars in repository.
58d998e 
If HOMEBREW_CELLAR (or HOMEBREW_PREFIX) are children of
HOMEBREW_REPOSITORY it’s important to deny write to the repository and
enable write to the Cellar/prefix afterwards.
@MikeMcQuaid MikeMcQuaid added the in progress Maintainers are working on this label Oct 11, 2016
@MikeMcQuaid MikeMcQuaid mentioned this pull request Oct 11, 2016
Closed
3 tasks
@MikeMcQuaid MikeMcQuaid merged commit 7a3ba92 into Homebrew:master Oct 12, 2016
@MikeMcQuaid MikeMcQuaid deleted the tweak-repo-sandbox branch October 12, 2016 07:38
@MikeMcQuaid MikeMcQuaid removed the in progress Maintainers are working on this label Oct 12, 2016
@tdsmith
Copy link
Contributor

tdsmith commented Oct 12, 2016

Thanks!

On Wed, Oct 12, 2016, 00:38 Mike McQuaid notifications@github.com wrote:

Merged #1261 #1261.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1261 (comment), or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAKnQelP1ghFp45D66zc1T-NS4qM5f4Hks5qzI5mgaJpZM4KTYaQ
.

@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilovezfs ilovezfs ilovezfs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MikeMcQuaid @tdsmith @ilovezfs